Fix: Resolve issue with "Update Subscription" button being always disabled for Stripe #7578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1326
Description
This PR fixes an issue where the “Update Subscription” button was always disabled, preventing users from updating subscription amounts. The issue affected both the Option Based Form Editor (V2) and the Visual Form Builder (VFB) forms.
The problem stemmed from a recently introduced
id
property in the subscription status object, which will only be available in the next release of Give Recurring. To ensure backwards compatibility, this fix adds a fallback to use a lowercased version of thelabel
property whenid
is not present.With this adjustment, the “Update Subscription” button will be correctly enabled, allowing users to update subscription amounts as expected, regardless of whether their data includes the new id property.
Affects
Manage Subscription on the Donor Dashboard
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks