Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add showToggle to amount descriptions option panel #7577

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix: add showToggle to amount descriptions option panel #7577

merged 1 commit into from
Oct 21, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Oct 21, 2024 •
edited by jira bot
Loading

Resolves GIVE-1325

Description

We recently updated the form builder library in core which included an update to the option panel component with a prop for showToggle that was not explicitly added to the amount level/description option panel implementation. This adds the prop to show the toggle.

Affects

  • V3 forms amount block level settings

Visuals

Screenshot 2024-10-21 at 11 01 11 AM

Testing Instructions

  • In form builder, Interact with the amount block and make sure the amount description work as expected

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein force-pushed the fix/amount-descriptions-GIVE-1325 branch from 2b33b2f to 3867276 Compare October 21, 2024 15:05
JoshuaHungDinh
JoshuaHungDinh approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go!

rickalday
rickalday approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@jonwaldstein jonwaldstein merged commit dee8ef3 into master Oct 21, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/amount-descriptions-GIVE-1325 branch October 21, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaHungDinh JoshuaHungDinh JoshuaHungDinh approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @rickalday @JoshuaHungDinh