Hot Fix: prevent PHP 8+ fatal errors when Tributes add-on is enabled #7572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1306
Description
The problem was happening on PHP 8+ because the
ltrim()
method on those versions is more restrictive about which type of parameter is accepted. In previous versions, not-string values only threw wanings but in PHP 8+ version it threw a fatal error that prevented the donation workflow.So, the solution was to prevent the use of values different from a string on the
ltrim()
method.Affects
Option-based forms with the Tributes add-on enabled.
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks