Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add Option-Based Form Editor feature flag #7571

Merged
merged 30 commits into from
Oct 22, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Oct 15, 2024

Resolves GIVE-1264

Description

This PR adds a new option to the Give > Settings > Advanced page that allows users to enable or disable the Option-Based Form Editor. This new option is enabled by default if the website has any Optio-Based forms on DB and disabled by default if it has only Visual Form Builder forms on DB.

Affects

The "Settings" page and the "Add campaign form" button

Visuals

image

image

image

image

Testing Instructions

Go to the Give > Settings > Advanced page to enable or disable the Option-Based Form Editor option and make sure the expected behaviors occur.

Expected behaviors with the legacy editor disabled:

  • Options used only by the legacy editor are hidden.
  • When the user clicks on the "Add campaign form" button, the Visual Form Builder is used by default.

Expected behaviors with the legacy editor enabled:

  • Options used only by the legacy editor have a helper text net to the label.
  • When the user clicks on the "Add campaign form" button, a modal that allows selecting which editor should be used, is displayed.

Expected behaviors in any scenario:

In both editors, you can find a link to return to the campaign overview page.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Oct 15, 2024
@glaubersilva glaubersilva changed the title Feature: add feature flags Feature: add Option-Based Form Editor feature flag Oct 17, 2024
@glaubersilva glaubersilva marked this pull request as ready for review October 17, 2024 20:53
@JasonTheAdams
Copy link
Contributor

@glaubersilva I wonder if this needs to be based on epic/campaigns? Is this something we only plan to release at the same time as campaigns, or would it be better to release this prior to?

cc: @jonwaldstein @angelablake

@glaubersilva
Copy link
Contributor Author

glaubersilva commented Oct 18, 2024

@JasonTheAdams This PR is based on the epic/campaigns branch because it touches on the Give\Campaigns domain, which is unavailable on the develop branch. But the new Give\FeatureFlags domain that this PR implements could be extracted to a separate PR based on the develop branch so we could release earlier only the new option that allows users to enable or disable the Option-Based Form Editor.

cc @jonwaldstein @angelablake

@jonwaldstein
Copy link
Contributor

@glaubersilva it would be ideal if we could release the feature flag setting before campaigns in order to start hiding legacy options specifically. Then when campaigns are introduced we would configure the flag for campaign screens specifically. Reason being, new customers are confused right now about legacy screens & settings and we still have a good amount of time before campaigns will be introduced.

Ideal order:

  1. Release feature flag setting(s) that hides v2 form settings & current views
  2. Release campaigns w/ updated feature flag setting(s) implementation

@glaubersilva glaubersilva requested a review from kjohnson October 18, 2024 15:13
@kjohnson
Copy link
Member

The button hover has a slight delay between the changes in the background color and the text color.

Also, as general feedback, I expected the whole block to be click-able and not just the button (which I thought was a label)[

Screencast.from.10-18-2024.03.22.01.PM.webm

Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments along the way - nothing stands out as a blocker.

@glaubersilva
Copy link
Contributor Author

@kjohnson Thanks for the suggestions! I just finished the implementation of the new design provided by @jdghinson last week.

image

@glaubersilva glaubersilva merged commit d2a5dd0 into epic/campaigns Oct 22, 2024
20 checks passed
@glaubersilva glaubersilva deleted the feature/feature-flag-GIVE-1264 branch October 22, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants