-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add Option-Based Form Editor feature flag #7571
Conversation
…re creating the form
…rg/givewp into feature/feature-flag-GIVE-1264
@glaubersilva I wonder if this needs to be based on |
@JasonTheAdams This PR is based on the |
@glaubersilva it would be ideal if we could release the feature flag setting before campaigns in order to start hiding legacy options specifically. Then when campaigns are introduced we would configure the flag for campaign screens specifically. Reason being, new customers are confused right now about legacy screens & settings and we still have a good amount of time before campaigns will be introduced. Ideal order:
|
src/FeatureFlags/OptionBasedFormEditor/OptionBasedFormEditor.php
Outdated
Show resolved
Hide resolved
The button hover has a slight delay between the changes in the background color and the text color. Also, as general feedback, I expected the whole block to be click-able and not just the button (which I thought was a label)[ Screencast.from.10-18-2024.03.22.01.PM.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some comments along the way - nothing stands out as a blocker.
@kjohnson Thanks for the suggestions! I just finished the implementation of the new design provided by @jdghinson last week. |
Resolves GIVE-1264
Description
This PR adds a new option to the
Give > Settings > Advanced
page that allows users to enable or disable the Option-Based Form Editor. This new option is enabled by default if the website has any Optio-Based forms on DB and disabled by default if it has only Visual Form Builder forms on DB.Affects
The "Settings" page and the "Add campaign form" button
Visuals
Testing Instructions
Go to the
Give > Settings > Advanced
page to enable or disable theOption-Based Form Editor
option and make sure the expected behaviors occur.Expected behaviors with the legacy editor disabled:
Expected behaviors with the legacy editor enabled:
Expected behaviors in any scenario:
In both editors, you can find a link to return to the campaign overview page.
Pre-review Checklist
@unreleased
tags included in DocBlocks