Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: disallow any serialized input in v2 forms #7566

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Refactor: disallow any serialized input in v2 forms #7566

merged 3 commits into from
Oct 9, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Oct 8, 2024 •
edited
Loading

Resolves GIVE-1296

Description

  • This updates our check for serialized input to inspect all incoming data.
  • This also adds extra validation for the company field

Affects

V2 form processing

Visuals

N/A

Testing Instructions

TBD

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the title Refactor: check for any serialized data in v2 forms Refactor: disallow any serialized input in v2 forms Oct 8, 2024
@jonwaldstein jonwaldstein marked this pull request as ready for review October 8, 2024 20:13
@jonwaldstein jonwaldstein changed the base branch from develop to master October 8, 2024 20:13
glaubersilva
glaubersilva requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonwaldstein I left a couple of comments to improve the serialized data checking.

includes/process-donation.php Show resolved Hide resolved
tests/includes/legacy/tests-functions.php Show resolved Hide resolved
glaubersilva
glaubersilva approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonwaldstein Nice work! Thanks for the changes, this is ready for QA.

rickalday
rickalday approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual and automated tests.

@jonwaldstein jonwaldstein changed the base branch from master to release/3.16.4 October 9, 2024 20:26
@jonwaldstein jonwaldstein merged commit db0ea4f into release/3.16.4 Oct 9, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/GIVE-1296 branch October 9, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaubersilva glaubersilva glaubersilva approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @rickalday @glaubersilva