Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Exclude P2P Campaigns from core query #7534

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Sep 5, 2024

Description

This PR excludes Peer-to-peer campaigns from the main Campaigns admin list table.

Affects

  • Adds a where clause to the CampaignRepository::prepareQuery() to exclude PEER_TO_PEER type.
  • Updates the campaign count in GetCampaignsListTable to use the prepared query.

Visuals

Before After
image image

Testing Instructions

Pre-review Checklist

  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Self Review of code and UX completed

@kjohnson kjohnson changed the base branch from develop to epic/campaigns September 5, 2024 15:35
@kjohnson kjohnson changed the title Chore/campaigns exclude p2p Refactor: Exclude P2P Campaigns from core query Sep 5, 2024
@kjohnson kjohnson marked this pull request as ready for review September 5, 2024 15:57
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@glaubersilva
Copy link
Contributor

Nice job!

@kjohnson kjohnson merged commit 979c5c0 into epic/campaigns Sep 10, 2024
20 checks passed
@kjohnson kjohnson deleted the chore/campaigns-exclude-p2p branch September 10, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants