Fix: Adjust design selector card height for Safari compatibility #7530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaHungDinh
changed the title
JoshuaHungDinh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: GIVE-1229 & #7518
Description
This PR sets the height of each design selector card to auto. It would seem the parent elements of the card do not have a set height and Safari is having trouble calculating what it should it be. This can be fixed by changing the parent grid to a flex system or setting the height to auto and allowing it to adjust it self. These changes introduce the latter.
Affects
Design Selector Card - new form template selecting modal
Visuals
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks