Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove extra focus outline in block preview #7528

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Fix: remove extra focus outline in block preview #7528

merged 5 commits into from
Sep 17, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Aug 30, 2024 •
edited by jira bot
Loading

Resolves: GIVE-1189

Description

A change in styling in WP 6.61 is causing an extra outline to appear on focused blocks within our Visual Form Builder. This PR removes this outline to eliminate the double line visual.

Affects

Visual Form Builder

Visuals

UI issue:

double-border

UI fixed:

remove-double-outline

Testing Instructions

  • While using the latest version of WP edit or create a new form.
  • Click on any block, you may need to click in between our block outline and the input.
  • Verify that this additional outline is no longer visible.
  • Ensure out block outline is still visible.
  • We must test this on the latest version and the previous 2 versions of WP.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the title Fix: remove extra focus borders in block preview Fix: remove extra focus outline in block preview Aug 30, 2024
JasonTheAdams
JasonTheAdams approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little polish! ✨

rickalday
rickalday approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests

@JoshuaHungDinh JoshuaHungDinh merged commit 538b118 into develop Sep 17, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the fix/build-block-preview-focus-border-wp-6.61 branch September 17, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonTheAdams JasonTheAdams JasonTheAdams approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaHungDinh @rickalday @JasonTheAdams