Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add migration to create initial campaigns from existing donation forms #7507

Merged
merged 9 commits into from
Aug 28, 2024

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Aug 21, 2024

Resolves GIVE-1139

Description

This PR adds a migration to create parent campaigns for existing donation forms.

Testing Instructions

From the develop branch with forms created, checkout the feature/campaigns-data-migration-1139 branch to enable Campaigns and trigger the related migrations.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@kjohnson kjohnson changed the base branch from develop to epic/campaigns August 21, 2024 18:07
@kjohnson kjohnson marked this pull request as ready for review August 28, 2024 17:37
@glaubersilva glaubersilva self-requested a review August 28, 2024 18:17
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjohnson Looks good to me. Nice work!

@kjohnson kjohnson merged commit 0b24a19 into epic/campaigns Aug 28, 2024
20 checks passed
@kjohnson kjohnson deleted the feature/campaigns-data-migration-1139 branch August 28, 2024 19:41
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjohnson looks good 👍
There is only one minor issue - wrong timestamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants