Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Add new tests for form migration steps #7505

Merged
merged 14 commits into from
Aug 24, 2024

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Aug 21, 2024

Resolves GIVE-926

Description

This PR adds tests for these FormMigration processes:

  • EmailSettings
  • FeeRecovery
  • FormExcerpt
  • FormFeaturedImage
  • FormFields
  • FormGrid
  • FormMeta
  • FormTitle
  • MigrateMeta
  • OfflineDonations
  • PaymentGateways
  • PdfSettings

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski changed the base branch from develop to test/form-migration-steps August 21, 2024 15:24
@pauloiankoski pauloiankoski marked this pull request as ready for review August 21, 2024 15:24
@pauloiankoski pauloiankoski force-pushed the test/form-migration-steps-new-tests branch from 06360b4 to c47c046 Compare August 21, 2024 15:29
@jonwaldstein jonwaldstein self-requested a review August 22, 2024 13:57
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@jonwaldstein jonwaldstein changed the base branch from test/form-migration-steps to develop August 22, 2024 13:57
@jonwaldstein jonwaldstein changed the base branch from develop to test/form-migration-steps August 22, 2024 13:58
Base automatically changed from test/form-migration-steps to develop August 22, 2024 23:33
@pauloiankoski pauloiankoski force-pushed the test/form-migration-steps-new-tests branch from e50b3a6 to 4bc4b0c Compare August 23, 2024 20:19
@pauloiankoski pauloiankoski merged commit e1b19af into develop Aug 24, 2024
20 checks passed
@pauloiankoski pauloiankoski deleted the test/form-migration-steps-new-tests branch August 24, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants