Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update donor dashboard user role check to include give_subscriber #7487

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix: update donor dashboard user role check to include give_subscriber #7487

merged 1 commit into from
Aug 14, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Aug 13, 2024 •
edited by jira bot
Loading

Resolves GIVE-1118

Description

This updates the donor dashboard to include the "Give Subscriber" role in permissions check.

Affects

The donor dashboard aceess

Visuals

Screenshot 2024-08-13 at 10 15 54 AM Screenshot 2024-08-13 at 10 16 02 AM

Testing Instructions

  • Create a donor/subscriber with Give Subscriber role
  • Access the donor dashboard and make sure you can view donation history

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the base branch from develop to master August 13, 2024 14:17
@jonwaldstein jonwaldstein requested a review from alaca August 13, 2024 14:17
@jonwaldstein jonwaldstein marked this pull request as ready for review August 13, 2024 14:57
alaca
alaca approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

rickalday
rickalday approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passe manual QA tests.

@jonwaldstein jonwaldstein changed the base branch from master to develop August 14, 2024 15:24
@jonwaldstein jonwaldstein merged commit 7f4424b into develop Aug 14, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/GIVE-1118 branch August 14, 2024 15:25
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
@jonwaldstein @kjohnson
Fix: update donor dashboard user role check to include give_subscriber (
41d751a 
#7487)

Co-authored-by: Jon Waldstein <jonwaldstein@jwaldstein-mbp.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaca alaca alaca approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @rickalday @alaca