Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Remove side effects from data provider #7478

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Refactor: Remove side effects from data provider #7478

wants to merge 5 commits into from

Commits on Sep 5, 2024

  1. Refactor: Remove side effects from data provider 

    - Eliminated side effects in test_give_meta_helpers data provider
- Ensures consistent test environment regardless of --filter usage

This change prevents unexpected failures when running specific tests
with PHPUnit's --filter option.
    David GABISON committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    05e24d3 View commit details
    Browse the repository at this point in the history

  2. fix: Corrects expected values after removing edge effect

    David GABISON committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6784617 View commit details
    Browse the repository at this point in the history

  3. fix: avoid instantiating the class multiple times 

    double declaration of `add_filter('..._post_meta')` breaks the return
value. See test: Tests_MISC_Functions::test_give_meta_helpers
    David GABISON committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    292da87 View commit details
    Browse the repository at this point in the history

  4. fix: Explain ENGINE=InnoDB to be able to use TRANSACTION in tests 

    MyIsam engine does not support transactions
    David GABISON committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    031772e View commit details
    Browse the repository at this point in the history

  5. fix: misprint

    David GABISON committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    30a6faf View commit details
    Browse the repository at this point in the history