Refactor: remove StellarBanner #7472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
requested changes
Aug 15, 2024
src/Promotions/ServiceProvider.php
Outdated
| @@ -62,12 +62,6 @@ private function bootPluginUpsells() | |||
| Hooks::addAction('admin_enqueue_scripts', SaleBanners::class, 'loadScripts'); | |||
There was a problem hiding this comment.
We should prevent scripts from loading too
There was a problem hiding this comment.
Resolved: 44dad57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : GIVE-1089
Description
Two separate errors reports were submitted for the recent StellarSaleBanner. One due to the session variables and the users unique setup & another from the FormGrid shortcode. These errors caused site crashes for these users. Due to the possibility of it affecting other users and in preparation of the v3 form as default. The Banner should be removed for now.
During the next banner another method to handle banner alterations will need to be considered.
Related initial task references:
Affects
Banner
Visuals
N/A
Testing Instructions
N/A
Pre-review Checklist
@unreleasedtags included in DocBlocks