Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove try the form builder messages on the Donations Form page #7451

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jul 16, 2024

Resolves GIVE-964

Description

These changes remove the Try the form builder button and the related banner from displaying on the Donations Form page.

The button is still visible on all v2 form adding/editing pages as well as the DonationForm page legacy view. This buttons text has also been updated to "Use the new visual form builder."

Affects

Donations Form page

Visuals

Screen.Recording.2024-07-17.at.10.34.14.AM.mov

Testing Instructions

  • Verify the try the form builder button is removed and does NOT display on the Donations Form page, unless in "Legacy view".
  • Verify the try the form builder banner is removed and does NOT display on the Donations Form page.
  • Verify the try the form builder button is still visible on all v2 Donation Form editing & adding pages.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see +1 -17. LGTM.

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@JoshuaHungDinh JoshuaHungDinh merged commit f83c6c9 into develop Jul 30, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/try-form-builder-button branch July 30, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants