Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add new link for the "Add Form" admin menu to create forms with the new visual form builder #7448

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Jul 12, 2024

Resolves GIVE-998

Description

This PR replaces the default "Add Form" link added by the WP Core for custom post types with a new link that uses the visual form builder as default editor.

As we don't have any filter to change this value, the global $submenu; var was used to accomplish that.

Affects

The "Add Form" admin menu link.

Visuals

Here is a sample of how the global $submenu; var looks like:

image

Testing Instructions

  1. Open the WP Admin area;
  2. Click on the "Add Form" submenu from Give;
  3. A new form using the Visual Form Builder should be created.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Jul 12, 2024
@glaubersilva glaubersilva changed the title Feature: add new link for the "Add Form" admin menu Feature: add new link for the "Add Form" admin menu to create forms with the new visual form builder Jul 12, 2024
@glaubersilva glaubersilva marked this pull request as ready for review July 12, 2024 18:58
@glaubersilva
Copy link
Contributor Author

@pauloiankoski This is ready for re-review.

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass manual QA tests.

@glaubersilva glaubersilva merged commit 8bc0bfc into develop Jul 30, 2024
20 checks passed
@glaubersilva glaubersilva deleted the feature/form-builder-submenu-link-GIVE-998 branch July 30, 2024 18:13
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants