Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add user capability check for Onboarding #7443

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix: add user capability check for Onboarding #7443

merged 2 commits into from
Jul 16, 2024

Conversation

alaca
Copy link
Member

@alaca alaca commented Jul 10, 2024 •
edited by jira bot
Loading

Resolves GIVE-981

Description

This PR adds a user capability check for the Onboarding page.

Affects

Onboarding page

  • Relevant @unreleased tags included in DocBlocks
  • Self Review of code and UX completed

@alaca alaca requested a review from jonwaldstein July 10, 2024 15:22
jonwaldstein
jonwaldstein approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonwaldstein
Copy link
Contributor

Build for QA: https://github.com/impress-org/givewp/actions/runs/9943468764

rickalday
rickalday approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@jonwaldstein jonwaldstein merged commit 5f67bf0 into develop Jul 16, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/onboarding-page-GIVE-981 branch July 16, 2024 15:36
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
@alaca @kjohnson
Fix: add user capability check for Onboarding (#7443)
3f425ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonwaldstein jonwaldstein jonwaldstein approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alaca @jonwaldstein @rickalday