Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make Stripe Element gateway work with the API keys connection method #7415

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix: make Stripe Element gateway work with the API keys connection method #7415

merged 1 commit into from
Jun 24, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Jun 17, 2024 •
edited
Loading

Resolves GIVE-843

Description

This PR fixes the bug that prevents the Stripe Element gateway from working in setups using the API keys connection method.

Now we are using only stripeKey to load the Stripe script (when stripeConnectedAccountId is missing) to prevent errors when the account is connected through API keys.

Affects

The Stripe Element Gateway

Visuals

image

image

Testing Instructions

  1. In the settings page, connect your Stripe Account using the API key method.
  2. Load a V3 form with the Stripe Element gateway and make sure it is loaded and working.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva
fix: Use only stripeKey to load the Stripe script (when stripeConnect…
b6fc2c1 
…edAccountId is missing) to prevent errors when the account is connected through API keys
@glaubersilva glaubersilva self-assigned this Jun 17, 2024
jonwaldstein
jonwaldstein approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do it 👍

rickalday
rickalday approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@glaubersilva glaubersilva merged commit 5fb0ffb into develop Jun 24, 2024
20 checks passed
@glaubersilva glaubersilva deleted the fix/stripe-element-api-keys-GIVE-843 branch June 24, 2024 19:00
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
@glaubersilva @kjohnson
Fix: make Stripe Element gateway work with the API keys connection me…
19525b4 
…thod (#7415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonwaldstein jonwaldstein jonwaldstein approved these changes

@rickalday rickalday rickalday approved these changes

Assignees

@glaubersilva glaubersilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glaubersilva @rickalday @jonwaldstein