Fix: return donation billing address in Stripe Payment Element Gateway #7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
changed the title
glaubersilva
approved these changes
May 31, 2024
There was a problem hiding this comment.
@jonwaldstein I just left a comment related to a missing unreleased tag. After adding that, it's ready for QA. Nice work!
| @@ -89,6 +89,9 @@ interface StripeGateway extends Gateway { | |||
| settings?: StripeSettings; | |||
| } | |||
|
|
|||
| /** | |||
| * @since 3.0.0 | |||
There was a problem hiding this comment.
I think we need an unreleased tag here as well to document the changes related to the address fields.
There was a problem hiding this comment.
resolved d6a35b0
jonwaldstein
changed the title
kjohnson
pushed a commit
that referenced
this pull request
Aug 21, 2024
#7395) Co-authored-by: Jon Waldstein <jonwaldstein@jwaldstein-mbp.mynetworksettings.com> Co-authored-by: Jon Waldstein <jonwaldstein@Jons-Air.EAP1200H>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: GIVE-831
Related (Recurring): https://github.com/impress-org/give-recurring/pull/1205
Description
This updates the Stripe Payment Element gateway to send the billing address details (supplied by the billing address block) to Stripe.
Also note that Stripe recommends using their address element that we can also explore
Affects
Stripe payment element gateways
Visuals
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks