Fix: sanitize shortcode atts #7379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an addition to #7375
In the previous PR, sanitization is added to input args only, but that won't be enough if the malicious code is already saved in the database. To fix this, sanitization of the data before output is also added.
Affects
give_formshortcodeTesting Instructions
Install and activate Give
Create a form using "Legacy Form" template
Create a new Post and add a shortcode
[give_form id="13721" display_style='abcdef"onmouseover=alert(123) b=']Replace id with form id
Open the post and move the mouse on the button
Pre-review Checklist
@unreleasedtags included in DocBlocks