-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add phone number to donor profile #7331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaubersilva
changed the title
Feature: add phone column to donors' table
Feature: add phone number to donor profile
Mar 26, 2024
…t_intl_tel_input_i18n_json_object method
jonwaldstein
requested changes
Mar 28, 2024
@jonwaldstein This is ready for re-review. |
jonwaldstein
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaubersilva great job man ☎️ ! ready for QA 🌈
rickalday
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-531
Description
This PR adds a phone input to the donor profile page. The International Telephone Input JS library (sponsored by Twilio) was used to make sure that the numbers were stored in the proper format regardless of the donor country.
The big advantage of using this JS library is that we can validate the numbers for all countries before submitting the form and store the donor phone number using the international format - which can be useful in the future if we decide to implement some kind of integration with 3rd party software to send SMS to donors because services like that (For example Twilio) require numbers in the international format.
The whole functionality was encapsulated in the
give_get_intl_tel_input()
function, this way we can reuse it in other places that require a phone input using only vanilla JS.In a subsequent PR, we also can create a version of this phone input in our form builder library to allow the use as a React Component.Edit: The library already provides a React Component that we can use when working in the Visual Form Builder or any other UI that uses React.Affects
The donor profile page.
Visuals
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks