Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add migration step for Fee Recovery settings #7025

Merged
merged 13 commits into from
Oct 11, 2023

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Oct 11, 2023

Description

In this pull request, we add a new step to move Fee Recovery settings from a v2 form to the new v3 form.

Affects

Form Migrations

Testing Instructions

  1. Create v2 forms
  2. Set Fee Recovery in many different combinations
  3. Migrate those forms
  4. Confirm your choices in v2 are reflected in the recently created v3 form

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

src/FormMigration/FormMetaDecorator.php Outdated Show resolved Hide resolved
src/FormMigration/Steps/FeeRecovery.php Outdated Show resolved Hide resolved
src/FormMigration/FormMetaDecorator.php Outdated Show resolved Hide resolved
src/FormMigration/FormMetaDecorator.php Outdated Show resolved Hide resolved
src/FormMigration/FormMetaDecorator.php Show resolved Hide resolved
src/FormMigration/Steps/FeeRecovery.php Show resolved Hide resolved
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@pauloiankoski pauloiankoski merged commit 8bfbef9 into release/3.0.0 Oct 11, 2023
20 checks passed
@pauloiankoski pauloiankoski deleted the feature/fee-recovery-migration branch October 11, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants