Fix: address minor form migration issues that could result in fatal errors

[pauloiankoski]

Description

During the testing of Form Migrations, we encountered errors caused by minor code details. This pull request aims to resolve those issues and ensure smooth Form Migrations.

This is a summary of the changes:

• Previously, if the attributes customAmountMin and customAmountMax were empty, they were saved as 0.0 post rounding implementation. Now, a validity check is performed on these attributes before rounding and saving them to ensure accurate data storage.
• Identified an issue where email notifications in P2P contained open-quotes, which interfered with form settings while extracting JSON content. This has been resolved by replacing open-quotes with double-quotes before setting the notifications in the migrated form.
• Noticed a migration step that saved the form prematurely before the migration was fully completed. This was unnecessary and had the potential to trigger unexpected side effects. This step has been rectified to ensure the form is saved only after the migration process is entirely finalized.

Affects

Form Migrations

Testing Instructions

1. Create a new P2P campaign that creates a new form for you.
2. Open that recently created form and migrate it to v3.
3. The form is migrated with no errors.

Pre-review Checklist

• Acceptance criteria satisfied and marked in related issue
• Relevant @unreleased tags included in DocBlocks
• Includes unit tests
• Reviewed by the designer (if follows a design)
• Self Review of code and UX completed

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1205692499999974

[glaubersilva]

@pauloiankoski Nice work! Almost everything working as expected, I just left a comment about a minor detail related to the wrong quotes that still throws a fatal error.

[glaubersilva]

@pauloiankoski Thanks for the update. Now it worked as expected, so looks good to QA.

[rickalday]

Passed manual QA tests