Feature: debounce text-based form design settings #7019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
changed the title
JasonTheAdams
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Very nice, @jonwaldstein! I'm inclined to say let's rebase this to release/3.0.0 so it can go out with the 3.0 release. The UX is pretty bad without this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This debounces the text-based form design settings included:
Header Heading, Header Description, Donate Button Caption, Multi Step Button Text.
Affects
The form design settings.
Visuals
Testing Instructions
Interact with the updated form design settings, and make sure the preview is not re-rendering every key stroke.
Pre-review Checklist
@unreleasedtags included in DocBlocks