Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: replace custom block editor text domain with give #7017

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Refactor: replace custom block editor text domain with give #7017

merged 1 commit into from
Oct 10, 2023

Conversation

jonwaldstein
Copy link
Contributor

Description

This replaces all 'custom-block-editor' text domains with 'give'

Affects

text domains in blocks

Visuals

N/A

Testing Instructions

Make sure blocks work

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein requested a review from kjohnson October 10, 2023 15:11
JasonTheAdams
JasonTheAdams approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 👍

@jonwaldstein jonwaldstein merged commit 01814d9 into release/3.0.0 Oct 10, 2023
8 checks passed
@jonwaldstein jonwaldstein deleted the refactor/update-textdomain branch October 10, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjohnson kjohnson kjohnson approved these changes

@JasonTheAdams JasonTheAdams JasonTheAdams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @JasonTheAdams @kjohnson