Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add a starter for new or empty sections #7009

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Feature: Add a starter for new or empty sections #7009

merged 6 commits into from
Oct 9, 2023

Conversation

JasonTheAdams
Copy link
Contributor

@JasonTheAdams JasonTheAdams commented Oct 6, 2023 •
edited by jonwaldstein
Loading

Description

This PR resolves two problems:

  1. There was no way to drag-n-drop a block onto an empty section. Erm. 😬
  2. Empty sections were boring and provided no guidance to the user.

This adds a clickable area that the user can also drag blocks into. Check it the video below!

Affects

Sections that have no child blocks

Visuals

https://www.loom.com/share/712bb84378544f35ad5f81e01d97a77a?sid=04c3f4fa-eff8-4401-9785-719e8088e9a1

Pre-review Checklist

  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JasonTheAdams JasonTheAdams changed the title feature: add a starter for new or empty sections Feature: add a starter for new or empty sections Oct 6, 2023
jdghinson
jdghinson approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@jdghinson jdghinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

JasonTheAdams and others added 2 commits October 9, 2023 08:28
@JasonTheAdams @kjohnson
feature: make drag text translatable
195cd2c 
Co-authored-by: Kyle B. Johnson <kjohnson@users.noreply.github.com>
@JasonTheAdams
refactor: clean up a lot of unnecessary code from fork
0d80169
@JasonTheAdams JasonTheAdams requested a review from kjohnson October 9, 2023 15:26
kjohnson
kjohnson approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner.

@kjohnson
Copy link
Member

kjohnson commented Oct 9, 2023

Building for QA, see https://github.com/impress-org/givewp/actions/runs/6458891729.

@JasonTheAdams
Copy link
Contributor Author

Oh, sweet! Thank you! 🙌

@kjohnson kjohnson changed the title Feature: add a starter for new or empty sections Feature: Add a starter for new or empty sections Oct 9, 2023
@kjohnson
Copy link
Member

kjohnson commented Oct 9, 2023

@JasonTheAdams it looks like the release/3.0.0 branch may not contain the pipeline fix. The build keeps failing.

@JasonTheAdams
Copy link
Contributor Author

@kjohnson Hmm, that's possible. I may not have had the latest version of develop when I created the release branch. It's quite possible there's nothing on develop that shouldn't be in the release branch, so I think we should be safe to merge develop into the release branch.

@kjohnson kjohnson requested a review from pauloiankoski October 9, 2023 16:32
@JasonTheAdams
Copy link
Contributor Author

@pauloiankoski @kjohnson I believe I resolved the issues. Testing a zip generation now.

pauloiankoski
pauloiankoski approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to be working properly now, specifically related to the build.

rickalday
rickalday approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@JasonTheAdams JasonTheAdams merged commit d8ba2b5 into release/3.0.0 Oct 9, 2023
9 checks passed
@JasonTheAdams JasonTheAdams deleted the feature/empty-section-starter branch October 9, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdghinson jdghinson jdghinson approved these changes

@kjohnson kjohnson kjohnson approved these changes

@pauloiankoski pauloiankoski pauloiankoski approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JasonTheAdams @kjohnson @rickalday @pauloiankoski @jdghinson