Fix check in give_install_roles_on_network #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The $wp_roles->roles array is multidimensional, so checking in_array() will always return false, and the Give plugin will re-initialize roles and capabilities on every admin page load. Use array_key_exists() instead and get faster admin load times!
|
Thanks @jimwebb that's good to know. |
DevinWalker
pushed a commit
that referenced
this pull request
Oct 28, 2015
Fix check in give_install_roles_on_network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$wp_roles->rolesarray is multidimensional, so checking for the presence of thegive_managerrole by usingin_array()will always return false, and the plugin will re-initialize roles and capabilities on every admin page load (including admin-ajax calls). It's slowing down one of my clients' sites by about a second per page load. Usearray_key_exists()instead and get faster admin load times!