refactor: remove unnecessary description classes

impress-org · Dec 16, 2024 · eedfa46 · eedfa46
1 parent 17373a4
commit eedfa46
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 26 deletions.
diff --git a/src/Campaigns/resources/admin/components/CampaignFormModal/CampaignFormModal.module.scss b/src/Campaigns/resources/admin/components/CampaignFormModal/CampaignFormModal.module.scss
@@ -12,11 +12,6 @@
     label {
         font-size: 1rem;
     }
-
-    .description {
-        font-size: 14px;
-        margin-bottom: 0.4rem;
-    }
 }
 
 .fieldRequired {

diff --git a/src/Campaigns/resources/admin/components/CampaignFormModal/index.tsx b/src/Campaigns/resources/admin/components/CampaignFormModal/index.tsx
@@ -240,9 +240,7 @@ export default function CampaignFormModal({isOpen, handleClose, apiSettings, tit
                             <label htmlFor="title">
                                 {__("What's the title of your campaign?", 'give')} {requiredAsterisk}
                             </label>
-                            <div className={styles.description}>
-                                {__("Give your campaign a title that tells donors what it's about.", 'give')}
-                            </div>
+                            <span>{__("Give your campaign a title that tells donors what it's about.", 'give')}</span>
                             <input
                                 type="text"
                                 {...register('title', {required: __('The campaign must have a title!', 'give')})}
@@ -258,9 +256,7 @@ export default function CampaignFormModal({isOpen, handleClose, apiSettings, tit
                         </div>
                         <div className="givewp-campaigns__form-row">
                             <label htmlFor="shortDescription">{__("What's your campaign about?", 'give')}</label>
-                            <div className={styles.description}>
-                                {__('Let your donors know the story behind your campaign.', 'give')}
-                            </div>
+                            <span>{__('Let your donors know the story behind your campaign.', 'give')}</span>
                             <textarea
                                 {...register('shortDescription')}
                                 rows={4}
@@ -272,9 +268,9 @@ export default function CampaignFormModal({isOpen, handleClose, apiSettings, tit
                         </div>
                         <div className="givewp-campaigns__form-row">
                             <label htmlFor="image">{__('Add a cover image or video for your campaign.', 'give')}</label>
-                            <div className={styles.description}>
+                            <span>
                                 {__('Upload an image or video to represent and inspire your campaign.', 'give')}
-                            </div>
+                            </span>
                             <Upload
                                 id="givewp-campaigns-upload-cover-image"
                                 label={__('Cover', 'give')}
@@ -303,9 +299,7 @@ export default function CampaignFormModal({isOpen, handleClose, apiSettings, tit
                             <label htmlFor="goalType">
                                 {__('How would you like to set your goal?', 'give')} {requiredAsterisk}
                             </label>
-                            <span className={styles.description}>
-                                {__('Set the goal your fundraising efforts will work toward.', 'give')}
-                            </span>
+                            <span>{__('Set the goal your fundraising efforts will work toward.', 'give')}</span>
                             <div className={styles.goalType}>
                                 <GoalTypeOption
                                     type={'amount'}
@@ -383,9 +377,7 @@ export default function CampaignFormModal({isOpen, handleClose, apiSettings, tit
                                 <label htmlFor="title">
                                     {goalInputAttributes[selectedGoalType].label} {requiredAsterisk}
                                 </label>
-                                <span className={styles.description}>
-                                    {goalInputAttributes[selectedGoalType].description}
-                                </span>
+                                <span>{goalInputAttributes[selectedGoalType].description}</span>
                                 {selectedGoalType === 'amount' || selectedGoalType === 'amountFromSubscriptions' ? (
                                     <Currency
                                         name="goal"

diff --git a/src/Campaigns/resources/admin/components/FormModal/FormModal.module.scss b/src/Campaigns/resources/admin/components/FormModal/FormModal.module.scss
@@ -43,6 +43,7 @@
                     color: var(--givewp-grey-400);
                     font-size: 0.875rem;
                     line-height: 1.5;
+                    margin-bottom: 0.4rem;
 
                     strong {
                         color: var(--givewp-grey-500);

diff --git a/src/Campaigns/resources/admin/components/MergeCampaign/Form/Form.module.scss b/src/Campaigns/resources/admin/components/MergeCampaign/Form/Form.module.scss
@@ -37,10 +37,6 @@
         max-width: 100%;
     }
 
-    .description {
-        margin-bottom: 0.4rem;
-    }
-
     .notice {
         display: flex;
         margin: 1rem 0 -0.2rem 0;

diff --git a/src/Campaigns/resources/admin/components/MergeCampaign/Form/index.tsx b/src/Campaigns/resources/admin/components/MergeCampaign/Form/index.tsx
@@ -142,9 +142,7 @@ export default function MergeCampaignsForm({isOpen, handleClose, title, campaign
                             <label htmlFor="title">
                                 {__('Select your destination campaign', 'give')} {requiredAsterisk}
                             </label>
-                            <span className={styles.description}>
-                                {__('All selected campaigns will be merged into this campaign.', 'give')}
-                            </span>
+                            <span>{__('All selected campaigns will be merged into this campaign.', 'give')}</span>
                             <select {...register('destinationCampaignId', {valueAsNumber: true})} defaultValue="">
                                 <option value="" disabled hidden>
                                     {__('Choose from selected campaigns', 'give')}