refactor: make logic more readible with early returns

impress-org · Jan 17, 2025 · 3dbd9a6 · 3dbd9a6
1 parent 0e8d12c
commit 3dbd9a6
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Subscriptions/Models/Subscription.php b/src/Subscriptions/Models/Subscription.php
@@ -206,7 +206,11 @@ public function totalDonations(): int
      */
     public function shouldEndSubscription(): bool
     {
-        return !$this->isIndefinite() && ($this->totalDonations() >= $this->installments);
+        if ($this->isIndefinite()) {
+            return false;
+        }
+
+        return $this->totalDonations() >= $this->installments;
     }
 
     /**