This repository was archived by the owner on Oct 16, 2023. It is now read-only.
Fix: Correct reference to Stripe Next Gen gateway when loading legacy Stripe code #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported by @Benunc, the Next Gen feature plugin was causing a break in form styles for the (legacy) Multi-Part template. I narrowed down the issue to the Next Gen Test Gateway and the (legacy) Stripe front-end files, which are included for the webhook listeners.
The
loadLegacyStripeWebhooksAndFilters()
method was checking for theNextGenTestGateway::class
to be "active", but should instead have been checking for theNextGenStripeGateway::class
- a simple typo in the code and oversight during code review.Additionally, there issue revealed a bug in the legacy Stripe code, in which a callback for the filter hook
give_form_html_tags
returnedfalse
if no Stripe gateways were active when the filter hook expects an array to always be returned.Visuals
Testing Instructions
Using a (legacy) Multi-Part form template: