Skip to content
This repository was archived by the owner on Oct 16, 2023. It is now read-only.

Fix: Correct reference to Stripe Next Gen gateway when loading legacy Stripe code #164

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

kjohnson
Copy link
Contributor

@kjohnson kjohnson commented Apr 11, 2023

Description

As reported by @Benunc, the Next Gen feature plugin was causing a break in form styles for the (legacy) Multi-Part template. I narrowed down the issue to the Next Gen Test Gateway and the (legacy) Stripe front-end files, which are included for the webhook listeners.

The loadLegacyStripeWebhooksAndFilters() method was checking for the NextGenTestGateway::class to be "active", but should instead have been checking for the NextGenStripeGateway::class - a simple typo in the code and oversight during code review.

Additionally, there issue revealed a bug in the legacy Stripe code, in which a callback for the filter hook give_form_html_tags returned false if no Stripe gateways were active when the filter hook expects an array to always be returned.

Visuals

Broken Fixed
image image

Testing Instructions

Using a (legacy) Multi-Part form template:

  • Toggle the Next Gen Test Gateway
  • Check the form field styles

Copy link
Contributor

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, @kjohnson! Please shoot this over to QA for a quick test.

Copy link
Member

@Benunc Benunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appears to work now! :shipit:

@JasonTheAdams JasonTheAdams merged commit f68f59b into develop Apr 12, 2023
@JasonTheAdams JasonTheAdams deleted the fix/multi-part-form-style-break branch April 12, 2023 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants