Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.9.0 bump #372

Merged
merged 2 commits into from
Jun 13, 2016
Merged

v1.9.0 bump #372

merged 2 commits into from
Jun 13, 2016

Conversation

benmosher
Copy link
Member

@benmosher benmosher commented Jun 9, 2016

There are more things I had hoped to complete during this release, but it's been a while so probably best to ship what's done, first.

  • get the old once-over and signoff from @jfmengels
  • tag
  • publish to next
  • give it a day
  • move to latest

officially broken, can't release as-is

@jfmengels
Copy link
Collaborator

Let's do this :)

@benmosher
Copy link
Member Author

FYI @lukeapage, @le0nik, @josh: just published 1.9.0 to next tag on npm. Let me know if you have issues.

@benmosher
Copy link
Member Author

Once this goes green I'll move to master, but 1.9.0 is officially broken, so it will never move to next 😓 .

@lukeapage and @le0nik I need you two to provide feedback on my changes in e044e37, ideally in the form of additional tests.

@jfmengels
Copy link
Collaborator

What are the problems?

@lukeapage
Copy link
Contributor

@benmosher a quick review of it looks good, i can try it out on our repo soon.

@lukeapage
Copy link
Contributor

confirmed, it still works nicely for my use case (also the one I added a test for)

@benmosher
Copy link
Member Author

@jfmengels the new custom resolver stuff tries to load actual Webpack instead of the Webpack resolver plugin, due to the original precedence order.

Doesn't show up in tests because Webpack isn't installed, but it happened immediately when I tried it in my actual project. 😅

@benmosher benmosher merged commit f348c7a into master Jun 13, 2016
@benmosher benmosher deleted the release branch June 13, 2016 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants