Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run Travis against Linux and OS X #288

Closed
wants to merge 8 commits into from

Conversation

strawbrary
Copy link
Contributor

No description provided.

@strawbrary strawbrary mentioned this pull request Apr 27, 2016
@strawbrary
Copy link
Contributor Author

strawbrary commented Apr 27, 2016

Got the repro for #272!

@benmosher
Copy link
Member

Ah, sweet! I didn't realize it was that simple.

Can you rebase this commit against the node-v6 branch? I think I've got it fixed over there so all the tests should pass, then I can merge this in.

@strawbrary
Copy link
Contributor Author

Done!

@benmosher
Copy link
Member

Thanks! though I didn't realize a few commits from master had snuck in, so I just cherry-picked the OS commit over to #273.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants