Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] extensions: ignore unresolvable type-only imports #2271

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Oct 25, 2021

Revise #2270: Only ignore unresolvable type-only imports. For resolvable type-only imports (if using eslint-import-resolver-typescript, or customizing import/extensions), restore the pre-#2270 behavior.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems like it addresses the discomfort I had with #2270.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #2271 (0481dcf) into main (46c4709) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2271      +/-   ##
==========================================
+ Coverage   94.60%   94.64%   +0.03%     
==========================================
  Files          65       65              
  Lines        2688     2687       -1     
  Branches      888      889       +1     
==========================================
  Hits         2543     2543              
+ Misses        145      144       -1     
Impacted Files Coverage Δ
src/rules/extensions.js 100.00% <100.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c4709...0481dcf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants