no-unused-modules: ignore flow type exports
#1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolashenry
changed the title
no-unused-modules: ignore flow type importsno-unused-modules: ignore flow type exports
ljharb
reviewed
Sep 27, 2020
tests/src/rules/no-unused-modules.js
Outdated
| ], | ||
| invalid: [ | ||
| test({ | ||
| options: unusedExportsTypescriptOptions, | ||
| code: `export const b = 2;`, | ||
| parser: parser, | ||
| filename: testFilePath('./no-unused-modules/typescript/file-ts-b.ts'), | ||
| filename: testFilePath('./no-unused-modules/typescript/file-ts-b-2.ts'), |
There was a problem hiding this comment.
is there a way we could rework these tests so we don't have to change these existing ones, and so "b-2" could have a more meaningful name for the new tests?
There was a problem hiding this comment.
I needed to split them into files exporting unused exports (the files ending with "-2") and the files exporting used exports (the files without "-2") because the existing tests was only actually testing the unused case. I will rename those with better names.
| @@ -0,0 +1,3 @@ | |||
| // @flow strict | |||
| export type Bar = number; | |||
| export interface BarInterface {}; | |||
There was a problem hiding this comment.
please ensure every file has a trailing newline
ljharb
approved these changes
Oct 3, 2020
ljharb
force-pushed
the
feature/ignore-flow-type-imports
branch
from
aec5361
to
5ade156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1564 :