Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for require.resolve #1216

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add support for require.resolve #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions tests/src/rules/no-unresolved.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,23 @@ function runResolverTests(resolver) {
}],
}),

rest({
code: 'var bar = require.resolve("./baz")',
options: [{ commonjs: true }],
errors: [{
message: "Unable to resolve path to module './baz'.",
type: 'Literal',
}],
}),
rest({
code: 'require.resolve("./baz")',
options: [{ commonjs: true }],
errors: [{
message: "Unable to resolve path to module './baz'.",
type: 'Literal',
}],
}),

// amd
rest({
code: 'require(["./baz"], function (bar) {})',
Expand Down
11 changes: 9 additions & 2 deletions utils/moduleVisitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,15 @@ exports.default = function visitModules(visitor, options) {
// for CommonJS `require` calls
// adapted from @mctep: http://git.io/v4rAu
function checkCommon(call) {
if (call.callee.type !== 'Identifier') return
if (call.callee.name !== 'require') return
if (call.callee.type === 'Identifier') {
if (call.callee.name !== 'require') return
}
else if (call.callee.type === 'MemberExpression') {
if (call.callee.object.name !== 'require') return
if (call.callee.property.name !== 'resolve') return
}
else return

if (call.arguments.length !== 1) return

const modulePath = call.arguments[0]
Expand Down