Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is import/unambiguous included in recommended config but not in warnings config? #1063

Closed
briandipalma opened this issue Apr 5, 2018 · 1 comment
Closed

Why is import/unambiguous included in recommended config but not in warnings config? #1063

briandipalma opened this issue Apr 5, 2018 · 1 comment
Labels
help wanted

Comments

@briandipalma
Copy link
Contributor

Recommended includes import/unambiguous in it's warnings section; which causes a lot of noise unless you have a fully ES2015 modules code base, but it's not included in the warnings config. This seems inconsistent. I can create a PR to change one or the other. I'd prefer to remove it from recommended given it seems an issue that isn't live yet with no ESM support in node.
@ljharb
Copy link
Member

ljharb commented Apr 5, 2018

I agree that it shouldn’t be recommended in any form, since unambiguous grammar was rejected by TC39.

briandipalma added a commit to briandipalma/eslint-plugin-import that referenced this issue Apr 5, 2018
@briandipalma
Update recommended.js
93aa68d 
Closes import-js#1063
@briandipalma briandipalma mentioned this issue Apr 5, 2018
Merged
benmosher pushed a commit that referenced this issue Apr 9, 2018
@briandipalma @benmosher
Update recommended.js (#1066)
121b9e1 
Closes #1063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @briandipalma