Fix dynamic-import-chunkname validation regex

import-js · Sep 2, 2019 · ab4057a · ab4057a
1 parent 7ffbf03
commit ab4057a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/rules/dynamic-import-chunkname.js b/src/rules/dynamic-import-chunkname.js
@@ -30,7 +30,7 @@ module.exports = {
     const { webpackChunknameFormat = '[0-9a-zA-Z-_/.]+' } = config || {}
 
     const paddedCommentRegex = /^ (\S[\s\S]+\S) $/
-    const commentStyleRegex = /^( \w+: ("[^"]*"|\d+|false|true),?)+ $/
+    const commentStyleRegex = /^( \w+: ("[^"]*"|\/.*\/|\d+|false|true),?)+ $/
     const chunkSubstrFormat = ` webpackChunkName: "${webpackChunknameFormat}",? `
     const chunkSubstrRegex = new RegExp(chunkSubstrFormat)
 

diff --git a/tests/src/rules/dynamic-import-chunkname.js b/tests/src/rules/dynamic-import-chunkname.js
@@ -32,6 +32,30 @@ ruleTester.run('dynamic-import-chunkname', rule, {
       )`,
       options,
     },
+    {
+      code: `dynamicImport(
+        /* webpackInclude: /some-regex/ */
+        /* webpackChunkName: "someModule" */
+        'test'
+      )`,
+      options,
+    },
+    {
+      code: `dynamicImport(
+        /* webpackChunkName: "someModule" */
+        /* webpackInclude: /some-regex/ */
+        'test'
+      )`,
+      options,
+    },
+    {
+      code: `dynamicImport(
+        /* webpackExclude: /some-regex/ */
+        /* webpackChunkName: "someModule" */
+        'test'
+      )`,
+      options,
+    },
     {
       code: `dynamicImport(
         /* webpackChunkName: "Some_Other_Module" */