Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#303): use @nolyfill/is-core-module #305

Merged
merged 2 commits into from
Jul 23, 2024
Merged

fix(#303): use @nolyfill/is-core-module #305

merged 2 commits into from
Jul 23, 2024

Conversation

SukkaW
Copy link
Collaborator

@SukkaW SukkaW commented Jul 22, 2024 •
edited
Loading

cc @wojtekmaj @SunsetTechuila

Closes #303.

Use @nolyfill/is-core-module.

node: prefix only module (node:sea, node:test) doesn't exist in module.builtinModules, and I want ESLint to detect typos like node:slqite. So we will have to maintain a data set.

The differences between @nolyfill/is-core-module and is-core-module:

  • 0 dependency vs 1 dependency hasown (which then has a transitive dependency function-bind)
  • Use Set#has instead of the hasown package
  • Don't run the match against the Node.js version vs use the current Node.js version when not provided
  • 2.7 KiB installation size vs 72 KiB installation size

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9255279

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-import-resolver-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security Socket Security
Copy link

socket-security bot commented Jul 22, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nolyfill/is-core-module@1.0.39 unsafe 0 2.71 kB sukkaw

🚮 Removed packages: npm/restore-cursor@4.0.0

View full report↗︎

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 22, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

SunsetTechuila
SunsetTechuila approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@SunsetTechuila SunsetTechuila left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't run the match against the Node.js version

I'm not sure if this is an advantage

I wouldn't mind going back to using is-core-module (or maybe prefer that, since 72 kib size and 2 deps is not an issue for me), but this is ok too

@SukkaW
Copy link
Collaborator Author

SukkaW commented Jul 23, 2024 •
edited
Loading

I wouldn't mind going back to using is-core-module (or maybe prefer that), but this is ok too

I will go back to is-core-module as soon as is-core-module drops hasown and function-bind.

@SukkaW SukkaW added this pull request to the merge queue Jul 23, 2024
Merged via the queue into import-js:master with commit f8d7b82 Jul 23, 2024
9 checks passed
@SukkaW SukkaW deleted the change-is-core-module branch July 23, 2024 12:38
@github-actions github-actions bot mentioned this pull request Jul 14, 2024
Merged
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 9, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
1d330fa 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 10, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
52f8c78 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 11, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
a12342d 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 13, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
aac4034 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 14, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
2ed8fd4 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 15, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
6a77a34 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 16, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
7920059 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 17, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
4fbc345 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 18, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
413ae49 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 19, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
9f20f2f 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 20, 2024
@renovate
Update dependency eslint-import-resolver-typescript to v3.6.3
2e2caad 
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 |


## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363)

##### Patch Changes

-   [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size

-   [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunsetTechuila SunsetTechuila SunsetTechuila approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SukkaW @SunsetTechuila