Update generateUuid function to use crypto library fixed: #483 #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced Math.random with crypto.getRandomValues for secure UUID generation. Ensured each instance of useImpler hook gets a unique UUID. Signed-off-by: H_S <81474463+HarjobandeepSingh@users.noreply.github.com>
HarjobandeepSingh
changed the title
1 task
chavda-bhavik
temporarily deployed
to
Development
GitHub Actions
Inactive
|
Congratulations on your first merge request in Impler. And sorry for the late review @HarjobandeepSingh, please assign the merge requests to me next time for quick review. |
Ok |
chavda-bhavik
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Math.random with crypto.getRandomValues for secure UUID generation.