Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find and remove unused code using leftovers gem #420

Open
wants to merge 10 commits into
base: nz-justice-development
Choose a base branch
from
Open

Find and remove unused code using leftovers gem #420

wants to merge 10 commits into from

Commits on Sep 24, 2024

  1. Install leftovers gem for unused code analysis

    @lukearndt
    lukearndt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2a4c154 View commit details
    Browse the repository at this point in the history

  2. Add Analysis build step with leftovers job

    @lukearndt
    lukearndt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d58dd88 View commit details
    Browse the repository at this point in the history

  3. Add leftovers:keep comments to code I'm confident in

    @lukearndt
    lukearndt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9f8d21b View commit details
    Browse the repository at this point in the history

  4. Add leftovers rules that follow general patterns

    @lukearndt
    lukearndt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    152c7c1 View commit details
    Browse the repository at this point in the history

  5. Add keep annotations for unused has_many calls

    @lukearndt
    lukearndt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    093c209 View commit details
    Browse the repository at this point in the history

  6. Delete code that I'm confident is not called

    @lukearndt
    lukearndt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    77fda0b View commit details
    Browse the repository at this point in the history

  7. Add keep annotations + comments where I'm unsure

    @lukearndt
    lukearndt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b742999 View commit details
    Browse the repository at this point in the history

  8. Rename to .leftovers.yml and exclude vendor

    @lukearndt
    lukearndt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6c89f01 View commit details
    Browse the repository at this point in the history

  9. Remove leftovers:keep annotations to test CI

    @lukearndt
    lukearndt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a258c19 View commit details
    Browse the repository at this point in the history

  10. Revert "Remove leftovers:keep annotations to test CI" 

    This reverts commit a258c19.
    @lukearndt
    lukearndt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    74ec030 View commit details
    Browse the repository at this point in the history