Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated bindgen, which fixes the generated nullptr derefs in bindgen tests. #442

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Updated bindgen, which fixes the generated nullptr derefs in bindgen tests. #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
246d6ac
Updated `bindgen`, which fixes the generated nullptr derefs in `bindg…
kkysen Jun 7, 2022
42d169b
Removed comment explaining why `bindgen` needed to be updated, which …
kkysen Jun 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 68 additions & 50 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions c2rust-ast-exporter/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@ serde_bytes = "0.11"
serde_cbor = "0.11"

[build-dependencies]
# Should be updated once https://github.com/rust-lang/rust-bindgen/pull/2203 (5/17/2022) lands.
# It has already been merged, so I think it should land in the next release.
# This fixes https://github.com/rust-lang/rust-bindgen/issues/1651,
# which causes warnings for nullptr derefs (UB) in the generated bindgen tests.
bindgen = { version = "0.59", features = ["logging"] }
bindgen = { version = "0.60", features = ["logging"] }
clang-sys = "1.3"
# Pinning until https://github.com/rust-lang/cmake-rs/issues/131 is resolved
# Fixed by https://github.com/rust-lang/cmake-rs/pull/146 on 5/12/2022; waiting for next release.
Expand Down