Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 18 #103

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Node 18 #103

merged 4 commits into from
Oct 4, 2023

Conversation

aspalding
Copy link
Contributor

@aspalding aspalding commented Oct 3, 2023 •
edited
Loading

close #87

@aspalding aspalding requested a review from wmurphyrd October 3, 2023 18:36
@aspalding aspalding marked this pull request as ready for review October 3, 2023 18:36
wmurphyrd
wmurphyrd requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@wmurphyrd wmurphyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit on the changelog wording - the library already worked in node 18 and don't want users to think they have to update to support node 18

CHANGELOG.md Outdated Show resolved Hide resolved
@aspalding @wmurphyrd
Update CHANGELOG.md
ad292db 
Co-authored-by: Will Murphy <william@datatitian.com>
@wmurphyrd wmurphyrd self-requested a review October 4, 2023 13:58
@wmurphyrd wmurphyrd merged commit 3f4f8a0 into master Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmurphyrd wmurphyrd wmurphyrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail on node 18
2 participants
@aspalding @wmurphyrd