Data integrity issue in produceWithPatches

[james-pellow]

🐛 Bug Report

A case where calling produceWithPatches produces a correct next state, but incorrect patches.

To Reproduce

import { produceWithPatches, applyPatches } from "immer";

const item = { id: 1 };

const state = [item];

const [nextState, patches] = produceWithPatches(state, draft => {
  draft[0].id = 2;
  draft[1] = item;
});

const final = applyPatches(state, patches);

console.log("Next state:", nextState);
console.log("Patches:", patches);
console.log("Final:", final);

Expected behavior

I would expect nextState to deep equal final. nextState is correct while the result from applying patches is incorrect. The second operation in the patch is incorrect:

[ 
  { op: 'replace', path: [ 0, 'id' ], value: 2 },
  { op: 'add', path: [ 0 ], value: { id: 2 } } 
]

Notice how the value of patch 2 is the new value of draft[0], and it is applying it at draft[0].

Link to repro

Code Sandbox

Environment

• Immer v5.0.0
• Occurs with setUseProxies(true)
• Occurs with setUseProxies(false) (ES5 only)

[darthzeran]

D o you need to call apply patches inside of a produceWithPatches?

[aleclarson]

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀