-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strongly-typed circuit events. #704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitbound
requested review from
cmbankester,
dkattan,
colinblaise and
nlowreydufour
August 7, 2023 13:15
colinblaise
reviewed
Aug 8, 2023
colinblaise
reviewed
Aug 8, 2023
colinblaise
reviewed
Aug 8, 2023
colinblaise
reviewed
Aug 8, 2023
colinblaise
reviewed
Aug 8, 2023
colinblaise
reviewed
Aug 8, 2023
colinblaise
previously approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
colinblaise
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Blazor Server, the front-end maintains a persistent SignalR connection to the backend, which is called a
Circuit
. By default, the circuit is "hidden" from the developer and handled behind-the-scenes by the framework. If you want to send your own SignalR messages, you'd need to create a new client connection that connects to a hub.Alternatively, you can register your own
CircuitHandler
derivative, which allows you to add logic to the circuit. I opted for this route to reduce the number of connections. TheCircuitConnection
class is this customCircuitHandler
, which basically acts as a SignalR client.The initially implementation was hasty and sloppy. The incoming events had loosely typed data (in the
CircuitEvent
class), all the front-end state was stored in a singularClientAppState
service, and reactivity was added via untyped property changed handlers.This PR replaces the
CircuitEvent
with strongly-typed messages sent viaIMessenger
, andClientAppState
has been broken out into individual stores.Please read the following. Do not delete below this line.
Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.
This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.
While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:
A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/
By submitting this PR, you agree to the following: