Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Identity scaffolding. #693

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Fix Identity scaffolding. #693

merged 3 commits into from
Jul 31, 2023

Conversation

bitbound
Copy link
Collaborator

I still have some cleanup/fixing to do in regard to DB providers and migrations.

First thing is that I'm unable to self-delete an account via Identity UI because the UserManager class isn't doing cascade deletes on related tables.

I needed to import the DeletePersonalData page from the Identity UI and override it to use the DataService class instead.

However, the Identity scaffolding was failing because it wasn't recognizing the classes for Razor components that didn't have a code-behind partial class. These components are basically like Vue's SFC. After explicitly creating a partial class in CS, I was able to import the page and make the change.

It looks like a lot of changes, but it isn't really.

  • Commit 1: The majority of this is moving C# code from Razor components to partial classes in CS files.
    • I also updated NuGet packages and added detailed EF logging in dev environment.
    • Everything under the /Areas/Identity was auto-generated by scaffolding.
  • Commit 2: This was almost all done by the Identity scaffolding. The only thing I did was replaced UserManager with DataService when deleting the user.
  • Commit 3: Just updated the submodule.

Please read the following. Do not delete below this line.

Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.

This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.

While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:

A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/

By submitting this PR, you agree to the following:

You hereby assign copyright in this PR's code to the Remotely project and its copyright holder, Immense Networks, to be licensed under the same terms as the rest of the code. You agree to relinquish any and all copyright interest in the software, to the detriment of your heirs and successors.

@bitbound bitbound merged commit 58cf570 into master Jul 31, 2023
1 check passed
@bitbound bitbound deleted the tech/fix-identity-scaffolding branch July 31, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants