Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have some cleanup/fixing to do in regard to DB providers and migrations.
First thing is that I'm unable to self-delete an account via Identity UI because the
UserManager
class isn't doing cascade deletes on related tables.I needed to import the
DeletePersonalData
page from the Identity UI and override it to use theDataService
class instead.However, the Identity scaffolding was failing because it wasn't recognizing the classes for Razor components that didn't have a code-behind partial class. These components are basically like Vue's SFC. After explicitly creating a partial class in CS, I was able to import the page and make the change.
It looks like a lot of changes, but it isn't really.
/Areas/Identity
was auto-generated by scaffolding.UserManager
withDataService
when deleting the user.Please read the following. Do not delete below this line.
Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.
This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.
While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:
A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/
By submitting this PR, you agree to the following: