Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Proto forwarded header not being seen by ASP.NET Core. #554

Merged
merged 5 commits into from
Jan 7, 2023

Conversation

bitbound
Copy link
Contributor

@bitbound bitbound commented Jan 6, 2023

Changes:

  • Added Docker default host IP (172.17.0.1) to known proxies so it will accept all forwarded headers.
  • Updated documentation.
  • Fixed AudioCapturerWin so NAudio exceptions wouldn't cause Remotely to crash.
  • Refactored AudioCapturerWin for performance.
  • Set permissions on log file so non-elevated process can write to it.
  • Replaced some static Logger calls with ILogger<T>.

Please read the following. Do not delete below this line.

Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.

This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.

While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:

A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/

By submitting this PR, you agree to the following:

You hereby assign copyright in this PR's code to the Remotely project and its copyright holder, Immense Networks, to be licensed under the same terms as the rest of the code. You agree to relinquish any and all copyright interest in the software, to the detriment of your heirs and successors.

@bitbound bitbound merged commit 56ee561 into master Jan 7, 2023
@bitbound bitbound deleted the bug/forwarded-headers branch January 7, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant