Test against Rust 1.48 #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run CI against 1.48 as well as stable and beta Replace use of `bool_to_option` as it's in xtask, and would otherwise bump ~required version to 1.50
|
lol "gentle nudge towards and msrv" I respect it. thanks for the work. |
dbr
added a commit
to dbr/imgui-rs
that referenced
this pull request
Sep 13, 2021
Changes required: - Overloaded methods named slightly differently (e.g sys::igPlotHistogramFloatPtr to sys::igPlotHistogram_FloatPtr) - ImGuiNavInput_KeyMenu_ was removed upstream, so NavInput::INTERNAL_COUNT needed tweaked
dbr
added a commit
to dbr/imgui-rs
that referenced
this pull request
Sep 14, 2021
Changes required: - Overloaded methods named slightly differently (e.g sys::igPlotHistogramFloatPtr to sys::igPlotHistogram_FloatPtr) - ImGuiNavInput_KeyMenu_ was removed upstream, so NavInput::INTERNAL_COUNT needed tweaked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Rust 1.48 is the minimum required by the project (excluding one usage of
bool::thenin one of thextask submodulecommand), mainly due to the#[doc(alias = ..)]which was stabilized thenSo I've added this version to be tested in CI, so use of any newer things can be noticed and, at the very least, noted in changelog for a new release (pending a policy being decided in #402)
Additionally clippy will be run from this version to avoid the linter-whackamole problem, when a new stable adds new lints and suddenly fails CI on previously-accepted code