Simplified and optimized vector and quaternion use in Anamnesis #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoiaCode
reviewed
Sep 5, 2024
ergoxiv
force-pushed
the
hotfix/vector-and-quaternion-extensions
branch
from
27d9205 to
96dff29
Compare
…scene loading logic
ergoxiv
force-pushed
the
hotfix/vector-and-quaternion-extensions
branch
from
96dff29 to
2151ef3
Compare
|
This should be ready to merge, right? |
|
Yes, just needs a bump to the lib submodule. Ill push a new commit in a bit. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This pull request will be marked as draft until the changes in the XivToolsWpf library are reviewed and approved (Aether-Tools/AetherToolsWpf#2)
Proposed changes to Anamnesis' code to:
System.Numericstypes, which offer hardware-accelerated computations (i.e. performance benefits).System.Numericsvector and quaternion are structs under the hood, so their default layout is sequential and will act the same way as the current custom implementations when it comes to reading from and writing to memory.