IE8 Exception Fix #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "none" when a max-width style isn't specified.
|
When there's no max-width, behavior isn't currently defined. I think this patch will make the image behave as if max-width:100%, which isn't a bad default. I use Closure compiler on Advanced. |
|
Great, this solved the issue for me as well 👍 |
|
Could you modify the pull request to merge into the 'unstable' branch, so I can do the release? |
dancek
added a commit
to dancek/slimmage
that referenced
this pull request
Nov 12, 2014
This was referenced Nov 12, 2014
|
#36 has been merged, closing this as duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue where IE8 was throwing an exception. Turned out to be related to the "max-width" property returning the value of "none" when it isn't specified.
I can increment a version number and minimize the script, I just don't know which minimizer you use.