透過部がないPNGをJPEGに変換する独自改造の変換後拡張子をjpegに変更 #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CircleCIのテスト落ちてるけど手元でテスト通ってるのでマージ強行する |
imagemagickに起因する脆弱性を防ぐためのimagemagickポリシーに違反していた imagemagickのポリシーを変えるよりは変換後拡張子を変えたほうがリスクは低いと判断した
takayamaki
force-pushed
the
fix/png_convert
branch
from
c1ce2c4
to
7bb5e3c
Compare
|
引っかかってたのはこれ mastodon/config/imagemagick/policy.xml Line 25 in 1f76d62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imagemagickに起因する脆弱性を防ぐためのimagemagickポリシーに違反していた
imagemagickのポリシーを変えるよりは変換後拡張子を変えたほうがリスクは低いと判断した