Portfolio Slider Block #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new portfolio slider feature to the theme, updates dependencies, and updates the image sizes. Below are the most important changes:
New Portfolio Slider Feature:
homepage-builderJSON configuration, including fields for slider title, slides, slide images, slide titles, and slide links.content-front-page.blade.phpview, including Swiper integration for navigation, pagination, and autoplay functionality.app.jsand initialized the portfolio slider with the necessary configurations. [1] [2]Dependencies Update:
swiperas a new dependency inpackage.json.Image Sizes:
setup.php.This pull request introduces a new portfolio slider feature to the website theme. The changes include adding new image sizes, updating dependencies, and modifying various files to support the portfolio slider functionality.Portfolio Slider Feature:
site/web/app/themes/nynaeve/app/setup.php: Added a new image sizeportfolio-slidewith dimensions 800x500 pixels and a 16:10 aspect ratio.site/web/app/themes/nynaeve/package.json: Addedswiperas a new dependency to enable the slider functionality.site/web/app/themes/nynaeve/resources/acf-json/homepage-builder/group_581576e5add40.json: Added a new layoutportfolio_sliderwith sub-fields for slider title and slides, including image, title, and link fields. [1] [2]site/web/app/themes/nynaeve/resources/scripts/app.js: Imported Swiper and its modules, and initialized the portfolio slider with autoplay, navigation, and pagination features. [1] [2]site/web/app/themes/nynaeve/resources/views/partials/content-front-page.blade.php: Added a new section to render the portfolio slider, including the slider container, slides, pagination, and navigation elements.